Software Design/Minimize the diff between implementations of a strategy

From Wikiversity
Jump to navigation Jump to search

Checklist questions:

  • Aren't there any unnecessary code differences between classes that extend the same abstract class (like a strategy)?

Why[edit | edit source]

Why not[edit | edit source]

Common details between several (but not all) of the classes could be pulled up into another intermediate abstract class to eliminate repetition between the leaf classes. For example, if the class hierarchy looked like this:

├── SumAggregate
├── MinAggregate
├── MaxAggregate
└── HistogramAggregate

Factoring out ScalarAggregate would increase the difference between ScalarAggregate's subclasses (which now would have less code) and HistogramAggregate. The latter would then look more unique than before the refactoring.

├── ScalarAggregate
│   ├── SumAggregate
│   ├── MinAggregate
│   └── MaxAggregate
└── HistogramAggregate

Related[edit | edit source]